Enzyme support example #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelesh
requested review from
alexander-novo and
reid-g
and removed request for
stonecoldhughes
|
Very cool to see! |
nkoukpaizan
force-pushed
the
nicholson/enzyme-support
branch
from
65523d2 to
fd75087
Compare
…ath explicitly set in spack.yaml.
reid-g
requested changes
Jan 10, 2025
ashermancinelli
approved these changes
Jan 13, 2025
reid-g
approved these changes
Jan 13, 2025
pelesh
approved these changes
Jan 13, 2025
Comment on lines
+2
to
+3
| #install(TARGETS ${CMAKE_CURRENT_BINARY_DIR}/EnzymeLibCheck DESTINATION bin) | ||
|
|
There was a problem hiding this comment.
Do we want to install Enzyme targets or this is out of scope for this PR?
Comment on lines
+4
to
+7
| double square(double x) { | ||
| return x * x; | ||
| } | ||
|
|
There was a problem hiding this comment.
Should this be hard-wired double or configurable real_type?
pelesh
added a commit
that referenced
this pull request
Apr 14, 2025
* Preliminary support for automatic differentiation using Enzyme * Build GridKit with Enzyme as dependency * Add simple Enzyme tests * Add Spack package for GridKit. * gridkit +enzyme in CI. * Update README with Enzyme dependency. * Changed Enzyme add_custom_target name to fix build issues with Ninja. --------- Co-authored-by: Asher Mancinelli <ashermancinelli@gmail.com> Co-authored-by: Slaven Peles <peless@ornl.gov>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on earlier work from Asher and Slaven to add examples using the Enzyme automatic differentiation library.
There are two new tests compared to
developthat should pass.Building Enzyme from source is discussed in #23. I tested that approach as well as building LLVM and Enzyme through Spack, and both approaches work for this use-case.